In this session, we’ll look at the process of code review from start to finish discussing tools, strategies to maximize learning opportunities, and providing appropriate feedback on code. You’ll learn to use the tools and criteria we use to review core patches which you could use to evaluate code from 3rd party vendors, custom and contributed modules. Lessons learned from Drupal core processes which you can apply to your internal processes will be discussed.
In the Drupal issue queue, submitted code represents a personal investment by the developer. It takes time to consider a problem, craft a solution, roll the patch, and upload it to an issue. All too often, some of these patches slip through the cracks and go unreviewed for months or even years. Even though it may fix bugs, improve the UI, or add better documentation, each patch must be thoroughly reviewed before it can be committed. An imperfect patch, which may not be ready to commit yet, still represents an opportunity to educate developers about coding style, best practices, Drupal core gates, and/or the contribution process itself.
This session is intended for developers, module maintainers, and project managers with a programming background who want to learn to write reviews for patches, new project applications, third party or custom code internal to their organization.